Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable LeaderTransferTest unittest #4976

Merged
merged 2 commits into from
Dec 5, 2022
Merged

disable LeaderTransferTest unittest #4976

merged 2 commits into from
Dec 5, 2022
+1 −1

Conversation

cangfengzhs
Copy link
Contributor

It often times out

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added ready-for-testing PR: ready for the CI test ready for review labels Dec 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022 •
edited
Loading

Codecov Report

Base: 76.85% // Head: 76.82% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9565ab3) compared to base (4f1fe76).
Patch coverage: 95.79% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4976      +/-   ##
==========================================
- Coverage   76.85%   76.82%   -0.03%     
==========================================
  Files        1101     1105       +4     
  Lines       81227    81440     +213     
==========================================
+ Hits        62426    62567     +141     
- Misses      18801    18873      +72
Impacted Files Coverage Δ
src/graph/executor/algo/CartesianProductExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/InnerJoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/JoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/LeftJoinExecutor.h 100.00% <ø> (ø)
src/graph/optimizer/rule/RemoveNoopProjectRule.cpp 93.61% <ø> (ø)
src/graph/planner/plan/ExecutionPlan.h 100.00% <ø> (ø)
src/graph/planner/plan/PlanNode.h 89.42% <ø> (ø)
src/graph/planner/plan/PlanNodeVisitor.h 100.00% <ø> (ø)
src/graph/service/CloudAuthenticator.cpp 0.00% <0.00%> (ø)
src/graph/visitor/PrunePropertiesVisitor.h 50.00% <ø> (ø)
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27 critical27 merged commit 61d45b7 into vesoft-inc:master Dec 5, 2022
@wey-gu wey-gu mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@codesigner codesigner codesigner approved these changes

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

@pengweisong pengweisong Awaiting requested review from pengweisong

@SuperYoko SuperYoko Awaiting requested review from SuperYoko

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cangfengzhs @codecov-commenter @codesigner @critical27